Remove PENDING flag check in CMIS SM#825
Open
noaOrMlnx wants to merge 1 commit into
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: noaOrMlnx <noaor@nvidia.com>
noaOrMlnx
force-pushed
the
remove_cmis_sm_pending_check
branch
from
bfa41b9 to
398ffb8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CMIS state machine in sonic-xcvrd to stop waiting for the CMIS datapath “PENDING” flag during the DP_INIT phase, aligning behavior with CMIS-spec guidance and addressing the linked sonic-buildimage issue.
Changes:
- Removed the CMIS 5.x DP_INIT_PENDING check that could trigger
force_cmis_reinit()if the pending flag was not observed. - Relied on the subsequent
DataPathInitializedstate validation (already present in the next state) as the authoritative transition indicator.
| self.force_cmis_reinit(lport, retries + 1) | ||
| return | ||
|
|
||
| # Ensure the Datapath is NOT Activated unless the host Tx siganl is good. |
Comment on lines
1181
to
1184
| self.force_cmis_reinit(lport) | ||
| return | ||
|
|
||
| if hasattr(api, 'get_cmis_rev'): | ||
| # Check datapath init pending on module that supports CMIS 5.x | ||
| majorRev = int(api.get_cmis_rev().split('.')[0]) | ||
| if majorRev >= 5 and not self.check_datapath_init_pending(api, host_lanes_mask): | ||
| self.log_notice("{}: datapath init not pending".format(lport)) | ||
| self.force_cmis_reinit(lport, retries + 1) | ||
| return | ||
|
|
||
| # Ensure the Datapath is NOT Activated unless the host Tx siganl is good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed the check in CMIS SM that waits for PENDING flag.
This PR aims to fix sonic-net/sonic-buildimage#27582
Motivation and Context
The removed code block is not accurate according to CMIS spec - this flag is not a good indicator for states transition.
How Has This Been Tested?
This is only informational flag, so removing it cannot fail anything.
The next state check is the right indicator and already exists.
this was tested with CMIS host mgmt. modules.
Additional Information (Optional)